[PATCH] D51068: [Android] Default to -fno-math-errno

2018-08-22 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL340424: [Android] Default to -fno-math-errno (authored by pirama, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51068 Files:

[PATCH] D51068: [Android] Default to -fno-math-errno

2018-08-21 Thread Stephen Hines via Phabricator via cfe-commits
srhines accepted this revision. srhines added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains/Linux.cpp:913 +return false; + return Generic_ELF::IsMathErrnoDefault(); +} pirama wrote: > I tried to be

[PATCH] D51068: [Android] Default to -fno-math-errno

2018-08-21 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama added inline comments. Comment at: lib/Driver/ToolChains/Linux.cpp:913 +return false; + return Generic_ELF::IsMathErrnoDefault(); +} I tried to be defensive here in case the default changes in the future. I can simplify to just return true here if

[PATCH] D51068: [Android] Default to -fno-math-errno

2018-08-21 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama created this revision. pirama added reviewers: srhines, enh. Android's libm does not set errno. Repository: rC Clang https://reviews.llvm.org/D51068 Files: lib/Driver/ToolChains/Linux.cpp lib/Driver/ToolChains/Linux.h test/Driver/fast-math.c Index: test/Driver/fast-math.c