atanasyan added a comment.
In https://reviews.llvm.org/D51234#1213813, @ruiu wrote:
> If this piece of code used to be working correctly, there is another piece of
> code that adds `-flavor ld` to the command line. But if that's the case, this
> change wouldn't work because it constructs someth
On 2018-08-27, Rui Ueyama via Phabricator wrote:
ruiu added a comment.
If this piece of code used to be working correctly, there is another piece of code that
adds `-flavor ld` to the command line. But if that's the case, this change wouldn't work
because it constructs something like "ld.lld -
ruiu added a comment.
If this piece of code used to be working correctly, there is another piece of
code that adds `-flavor ld` to the command line. But if that's the case, this
change wouldn't work because it constructs something like "ld.lld -flavor ld
...". ld.lld doesn't accept `-flavor` op
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340709: [Driver] Change MipsLinux default linker from
"lld" to "ld.lld" (authored by MaskRay, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D5123
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D51234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
MaskRay created this revision.
MaskRay added a reviewer: kzhuravl.
Herald added subscribers: cfe-commits, atanasyan, jrtc27, arichardson, sdardis.
Repository:
rC Clang
https://reviews.llvm.org/D51234
Files:
lib/Driver/ToolChains/MipsLinux.h
Index: lib/Driver/ToolChains/MipsLinux.h
