[PATCH] D51258: Extract parseBindID method

2018-08-30 Thread Stephen Kelly via Phabricator via cfe-commits
steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Parser.cpp:362 +bool Parser::parseBindID(std::string , TokenInfo ) { + // Parse .bind("foo") klimek wrote: > CloseToken seems to not be used

[PATCH] D51258: Extract parseBindID method

2018-08-30 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL341141: Extract parseBindID method (authored by steveire, committed by ). Herald added a subscriber: llvm-commits.

[PATCH] D51258: Extract parseBindID method

2018-08-27 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: lib/ASTMatchers/Dynamic/Parser.cpp:362 +bool Parser::parseBindID(std::string , TokenInfo ) { + // Parse .bind("foo") CloseToken seems to not be used afterwards either here or in the follow-up patch? Repository:

[PATCH] D51258: Extract parseBindID method

2018-08-25 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D51258 Files: include/clang/ASTMatchers/Dynamic/Parser.h lib/ASTMatchers/Dynamic/Parser.cpp Index: lib/ASTMatchers/Dynamic/Parser.cpp