This revision was automatically updated to reflect the committed changes.
Closed by commit rL341553: [OpenCL] Relax diagnostics on OpenCL access
qualifiers (authored by asavonic, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51302?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341553: [OpenCL] Relax diagnostics on OpenCL access
qualifiers (authored by asavonic, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51302
Files:
lib/Sema/SemaDeclAttr.cpp
lib/Sema
AlexeySachkov updated this revision to Diff 163086.
AlexeySachkov added a comment.
Applied comment from Anastasia
https://reviews.llvm.org/D51302
Files:
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaType.cpp
test/SemaOpenCL/access-qualifier.cl
Index: lib/Sema/SemaType.cpp
==
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Comment at: test/SemaOpenCL/access-qualifier.cl:107
+
+kernel void image_wo_twice(write_only write_only image1d_t i){} //
expected-warning {{duplicate 'w
AlexeySachkov created this revision.
AlexeySachkov added reviewers: Anastasia, yaxunl.
Emit warning for multiple access qualifiers if they do not conflict.
Patch by Alexey Bader
Repository:
rC Clang
https://reviews.llvm.org/D51302
Files:
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaType.cpp