[PATCH] D51310: [clangd] Implement iterator cost

2018-08-30 Thread Kirill Bobyrev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE341057: [clangd] Implement iterator cost (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D51310?vs=163024&id=163297#toc Repository: rCTE Clang Tools Extra h

[PATCH] D51310: [clangd] Implement iterator cost

2018-08-29 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:93 + const std::unique_ptr &RHS) { +return LHS->cost() < RHS->cost(); + }); sammccall wrote: > (I'd actually suggest declaring

[PATCH] D51310: [clangd] Implement iterator cost

2018-08-29 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 163024. kbobyrev marked 6 inline comments as done. This revision is now accepted and ready to land. https://reviews.llvm.org/D51310 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp clang-tools-extra/clangd/index/dex/Iterator.h clang-tools-extra/u

[PATCH] D51310: [clangd] Implement iterator cost

2018-08-28 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. In https://reviews.llvm.org/D51310#1214548, @kbobyrev wrote: > It's probably better to roll out proximity path boosting & actual two-stage > filtering before rolling this out. Up to you (I don't understand the interaction), but this

[PATCH] D51310: [clangd] Implement iterator cost

2018-08-27 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev planned changes to this revision. kbobyrev added a comment. It's probably better to roll out proximity path boosting & actual two-stage filtering before rolling this out. https://reviews.llvm.org/D51310 ___ cfe-commits mailing list cfe-com

[PATCH] D51310: [clangd] Implement iterator cost

2018-08-27 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgrang, jkorous, MaskRay. This patch introduces iterator cost concept to improve the performance of Dex query iter