[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

2018-09-12 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. What is the call generated with -pg for AMR32, __gnu_mcount_nc or _mount? __gnu_mcount_nc with "-pg" is known to be broken ( https://bugs.llvm.org/show_bug.cgi?id=33845) Repository: rC Clang https://reviews.llvm.org/D51713

[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

2018-09-12 Thread Stephen Hines via Phabricator via cfe-commits
srhines added a comment. In https://reviews.llvm.org/D51713#1232414, @manojgupta wrote: > What is the call generated with -pg for AMR32, __gnu_mcount_nc or _mount? > __gnu_mcount_nc with "-pg" is known to be broken ( > https://bugs.llvm.org/show_bug.cgi?id=33845) I CCed myself on that issue

[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

2018-09-12 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. In https://reviews.llvm.org/D51713#1232497, @srhines wrote: > In https://reviews.llvm.org/D51713#1232414, @manojgupta wrote: > > > What is the call generated with -pg for AMR32, __gnu_mcount_nc or _mount? > > __gnu_mcount_nc with "-pg" is known to be broken ( > > ht

[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

2018-09-13 Thread Stephen Hines via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342165: Support -fno-omit-frame-pointer with -pg. (authored by srhines, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51713 Files: cfe/trunk/

[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

2018-09-05 Thread Stephen Hines via Phabricator via cfe-commits
srhines created this revision. Herald added a subscriber: cfe-commits. srhines added a subscriber: nickdesaulniers. Previously, any instance of -fomit-frame-pointer would make it such that -pg was an invalid flag combination. If -fno-omit-frame-pointer is passed later on the command line (such tha

[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

2018-09-05 Thread Stephen Hines via Phabricator via cfe-commits
srhines added a comment. This was discovered in the Android build system (which passes -fomit-frame-pointer by default for ARM configurations. This leads to the inability to specify -pg, since there is no way to override the mere presence of -fomit-frame-pointer. Repository: rC Clang https

[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

2018-09-05 Thread Stephen Hines via Phabricator via cfe-commits
srhines added a comment. http://b/32510864 was the internal bug request, so I am noting it here for future reference, but I think that the patch itself is pretty self-explanatory (rather than filing a distinct upstream bug about this issue). Repository: rC Clang https://reviews.llvm.org/D51