[PATCH] D51722: [OpenCL] Allow blocks to capture arrays in OpenCL

2018-09-17 Thread Andrew Savonichev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342370: [OpenCL] Allow blocks to capture arrays in OpenCL (authored by asavonic, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51722?vs=1642

[PATCH] D51722: [OpenCL] Allow blocks to capture arrays in OpenCL

2018-09-06 Thread Dmitry Sidorov via Phabricator via cfe-commits
sidorovd updated this revision to Diff 164214. sidorovd added a comment. Reference to the Spec was added https://reviews.llvm.org/D51722 Files: lib/Sema/SemaExpr.cpp test/SemaOpenCL/block-array-capturing.cl Index: test/SemaOpenCL/block-array-capturing.cl ==

[PATCH] D51722: [OpenCL] Allow blocks to capture arrays in OpenCL

2018-09-06 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! There is a small comment that can be addressed before the final commit. Thanks! Comment at: lib/Sema/SemaExpr.cpp:14627 - // Blocks are not allowed to capture

[PATCH] D51722: [OpenCL] Allow blocks to capture arrays in OpenCL

2018-09-06 Thread Dmitry Sidorov via Phabricator via cfe-commits
sidorovd created this revision. sidorovd added reviewers: Anastasia, yaxunl. Herald added a subscriber: cfe-commits. sidorovd added a comment. Previously this patch was reviewed here: https://reviews.llvm.org/D26794 . I wasn't able to update it, so I created a new one with the comments applied.

[PATCH] D51722: [OpenCL] Allow blocks to capture arrays in OpenCL

2018-09-06 Thread Dmitry Sidorov via Phabricator via cfe-commits
sidorovd added a comment. Previously this patch was reviewed here: https://reviews.llvm.org/D26794 . I wasn't able to update it, so I created a new one with the comments applied. Repository: rC Clang https://reviews.llvm.org/D51722 ___ cfe-commi