This revision was automatically updated to reflect the committed changes.
Closed by commit rL342749: [CUDA] Ignore uncallable functions when we check for
usual deallocators. (authored by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
tra updated this revision to Diff 166053.
tra added a comment.
Renamed last instance of 'Matches' -> 'PreventedBy'.
https://reviews.llvm.org/D51808
Files:
clang/include/clang/AST/DeclCXX.h
clang/include/clang/Sema/Sema.h
clang/lib/AST/DeclCXX.cpp
clang/lib/Sema/SemaDeclCXX.cpp
tra updated this revision to Diff 166050.
tra marked an inline comment as done.
tra added a comment.
Updated assertion message.
https://reviews.llvm.org/D51808
Files:
clang/include/clang/AST/DeclCXX.h
clang/include/clang/Sema/Sema.h
clang/lib/AST/DeclCXX.cpp
tra updated this revision to Diff 165794.
tra added a comment.
Addressed Richard's comments.
Moved clang-tidy changes into separate review https://reviews.llvm.org/D52179.
https://reviews.llvm.org/D51808
Files:
clang/include/clang/AST/DeclCXX.h
clang/include/clang/Sema/Sema.h
rsmith added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:551
if (Decl->isMain() || !Decl->isUserProvided() ||
-Decl->isUsualDeallocationFunction() ||
-Decl->isCopyAssignmentOperator() ||
tra added a comment.
@rsmith ping.
https://reviews.llvm.org/D51808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra created this revision.
tra added a reviewer: rsmith.
Herald added subscribers: bixia, jlebar, sanjoy.
Previously clang considered function variants from both sides of
compilation and that sometimes resulted in picking up wrong deallocation
function.
https://reviews.llvm.org/D51808
Files:
