kbobyrev closed this revision.
kbobyrev added a comment.
I think this one is addressed in the VByte patch, so I'm closing this revision
in order to prevent conflicts between these two.
https://reviews.llvm.org/D52084
___
cfe-commits mailing list
kbobyrev added a comment.
In https://reviews.llvm.org/D52084#1238537, @sammccall wrote:
> This change seems fine but...
>
> This representation with the raw DocIDs and position dumped seems mostly
> useful for debugging buggy iterator implementations, but not really useful
> for understanding
sammccall accepted this revision.
sammccall added a comment.
This change seems fine but...
This representation with the raw DocIDs and position dumped seems mostly useful
for debugging buggy iterator implementations, but not really useful for
understanding query structure and behavior.
I
kbobyrev updated this revision to Diff 165973.
kbobyrev marked an inline comment as done.
https://reviews.llvm.org/D52084
Files:
clang-tools-extra/clangd/index/dex/Iterator.h
clang-tools-extra/clangd/index/dex/PostingList.cpp
clang-tools-extra/unittests/clangd/DexTests.cpp
Index:
