[PATCH] D52151: Also manages clang-X as tool for scan-build

2018-09-16 Thread Jonathan Roelofs via Phabricator via cfe-commits
jroelofs added a comment. `$triple-clang`, also Repository: rC Clang https://reviews.llvm.org/D52151 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52151: Also manages clang-X as tool for scan-build

2018-09-16 Thread Kristina Brooks via Phabricator via cfe-commits
kristina added a comment. Just a minor suggestion, I think it would make it more clear as before LLVM 7, Clang did not have a version number with the main executable. GCC is slightly less consistent with their formats as they usually ship as host compilers with various suffixes, but with Clang

Re: [PATCH] D52151: Also manages clang-X as tool for scan-build

2018-09-16 Thread Jon Roelofs via cfe-commits
lgtm On Sun, Sep 16, 2018 at 12:47 PM Sylvestre Ledru via Phabricator < revi...@reviews.llvm.org> wrote: > sylvestre.ledru created this revision. > sylvestre.ledru added a reviewer: jroelofs. > > This will make > scan-build-7 clang-7 -c foo.c &> /dev/null > > > Repository: > rC Clang > >

[PATCH] D52151: Also manages clang-X as tool for scan-build

2018-09-16 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. @kristina sorry, I missed your comment. I just followed what we are doing with gcc. Do you want me to update it? Repository: rC Clang https://reviews.llvm.org/D52151 ___ cfe-commits mailing list

[PATCH] D52151: Also manages clang-X as tool for scan-build

2018-09-16 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC342350: Also manages clang-X as tool for scan-build (authored by sylvestre, committed by ). Changed prior to commit:

[PATCH] D52151: Also manages clang-X as tool for scan-build

2018-09-16 Thread Kristina Brooks via Phabricator via cfe-commits
kristina added a comment. Nitpick: This regex is far too broad to cover the rare use case where you'd be invoking clang as `clang-N`. I think something like `clang(?:\-[789])?` would be more suitable? Repository: rC Clang https://reviews.llvm.org/D52151

[PATCH] D52151: Also manages clang-X as tool for scan-build

2018-09-16 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: jroelofs. This will make scan-build-7 clang-7 -c foo.c &> /dev/null Repository: rC Clang https://reviews.llvm.org/D52151 Files: tools/scan-build/bin/scan-build Index: tools/scan-build/bin/scan-build