ioeric added inline comments.
Comment at: clangd/index/FileIndex.h:77
+ /// Update symbols from main file \p Path with symbols in \p TopLevelDecls.
+ void updateMain(PathRef Path, ASTContext &AST,
+ std::shared_ptr PP,
sammccall wrote:
> sammcc
sammccall added inline comments.
Comment at: clangd/index/FileIndex.h:77
+ /// Update symbols from main file \p Path with symbols in \p TopLevelDecls.
+ void updateMain(PathRef Path, ASTContext &AST,
+ std::shared_ptr PP,
sammccall wrote:
> can
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342460: [clangd] Merge ClangdServer::DynamicIndex into
FileIndex. NFC. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D5
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE342460: [clangd] Merge ClangdServer::DynamicIndex into
FileIndex. NFC. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D5?vs=165918&id=165923#toc
Repository
sammccall added inline comments.
Comment at: clangd/index/FileIndex.h:121
std::pair
indexAST(ASTContext &AST, std::shared_ptr PP,
llvm::ArrayRef URISchemes = {});
ioeric wrote:
> sammccall wrote:
> > indexPreamble would be clearer I think.
> What abou
ioeric added inline comments.
Comment at: clangd/index/FileIndex.h:121
std::pair
indexAST(ASTContext &AST, std::shared_ptr PP,
llvm::ArrayRef URISchemes = {});
sammccall wrote:
> indexPreamble would be clearer I think.
What about `indexHeaderSymbols`?
ioeric updated this revision to Diff 165918.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- addressed review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D5
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/index/FileIndex.cpp
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Glorious! Think the APIs could be simplified/clarified a little further, but up
to you.
Comment at: clangd/index/FileIndex.cpp:24
+indexSymbols(ASTContext &AST, std::s
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
FileIndex now provides explicit interfaces for preamble and main file updates.
This avoids growing parameter list when preamble and main sy
