[PATCH] D52264: Deduplicate replacements from diagnostics.

2018-09-25 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a subscriber: bkramer. ioeric added a comment. I wasn't aware of the bug. I have just replied to the issue. Thanks for letting me know! Repository: rL LLVM https://reviews.llvm.org/D52264 ___ cfe-commits mailing list

Re: [PATCH] D52264: Deduplicate replacements from diagnostics.

2018-09-25 Thread Eric Liu via cfe-commits
I wasn't aware of the bug. I have just replied to the issue. Thanks for letting me know! On Tue, Sep 25, 2018 at 10:44 AM Stephen Kelly via Phabricator < revi...@reviews.llvm.org> wrote: > steveire added a comment. > > Was this motivated by https://bugs.llvm.org/show_bug.cgi?id=38910 ? > > >

[PATCH] D52264: Deduplicate replacements from diagnostics.

2018-09-25 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. Was this motivated by https://bugs.llvm.org/show_bug.cgi?id=38910 ? Repository: rL LLVM https://reviews.llvm.org/D52264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52264: Deduplicate replacements from diagnostics.

2018-09-25 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342951: Deduplicate replacements from diagnostics. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52264: Deduplicate replacements from diagnostics.

2018-09-24 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52264: Deduplicate replacements from diagnostics.

2018-09-19 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added a reviewer: bkramer. Herald added a subscriber: cfe-commits. After r329813, clang-apply-replacements stopped deduplicating identical replacements; however, tools like clang-tidy relies on the deduplication of identical dignostics replacements from