ilya-biryukov updated this revision to Diff 173340.
ilya-biryukov added a comment.
- Rebase and update after dependent changes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52274
Files:
clangd/index/Index.cpp
clangd/index/Index.h
clangd/index/SymbolCollector.cpp
clang
ilya-biryukov created this revision.
ilya-biryukov added reviewers: ioeric, sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
And add a hidden option to control whether the types are collected.
For experiments, will be removed when expected types implementation
is stabiliz
ilya-biryukov planned changes to this revision.
ilya-biryukov added a comment.
Need to store the types in RIFF format too
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
sammccall added inline comments.
Comment at: clangd/index/Index.cpp:118
+static void own(Symbol &S, UniqueStringSaver &Strings,
+BumpPtrAllocator &Arena) {
visitStrings(S, [&](StringRef &V) { V = Strings.save(V); });
why these changes?
==
ilya-biryukov updated this revision to Diff 175103.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Remove accidental changes
- Add types to binary serialization
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52274
Files:
clangd/index/Index.h
ilya-biryukov updated this revision to Diff 175104.
ilya-biryukov added a comment.
- Remove another accidental change
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52274
Files:
clangd/index/Index.h
clangd/index/Serialization.cpp
clangd/index/SymbolCollector.cpp
clangd/
ilya-biryukov added inline comments.
Comment at: clangd/index/Index.cpp:118
+static void own(Symbol &S, UniqueStringSaver &Strings,
+BumpPtrAllocator &Arena) {
visitStrings(S, [&](StringRef &V) { V = Strings.save(V); });
sammccall wrote:
> why
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/Index.h:283
+ /// Type of the symbol, used for scoring purposes.
+ llvm::StringRef Type;
either call this OpaqueType o
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added inline comments.
Comment at: clangd/index/Index.h:283
+ /// Type of the symbol, used for scoring purposes.
+ llvm::StringRef Type;
sammccall wrote:
> either call this OpaqueType or point at i
ilya-biryukov updated this revision to Diff 175246.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Bump the RIFF version number
- Place the Type field after the ReturnType
- Address other comments
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
ilya-biryukov updated this revision to Diff 175254.
ilya-biryukov added a comment.
- Remove unused #include
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52274/new/
https://reviews.llvm.org/D52274
Files:
clangd/index/Index.h
clangd/index/Serial
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347560: [clangd] Collect and store expected types in the
index (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://r
12 matches
Mail list logo