ebevhan added inline comments.
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1119
+ case ISD::SSAT:
+// Target legalization checked here?
+Action = TargetLowering::Expand;
leonardchan wrote:
> ebevhan wrote:
> > leonardchan wrote:
> > > ebevhan wr
leonardchan added inline comments.
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1119
+ case ISD::SSAT:
+// Target legalization checked here?
+Action = TargetLowering::Expand;
ebevhan wrote:
> leonardchan wrote:
> > ebevhan wrote:
> > > leonardcha
ebevhan added inline comments.
Comment at: include/llvm/CodeGen/ISDOpcodes.h:264
+/// signed value is returned instead.
+SSAT,
+
leonardchan wrote:
> ebevhan wrote:
> > leonardchan wrote:
> > > ebevhan wrote:
> > > > With the way the rest is written, it d
leonardchan added a comment.
Of the intrinsics we plan to implement, it seems that the ordering of
legalization affects specifically the fixed point mul/div intrinsics since if
they get expanded into other nodes, we will need to check again for legal types
since performing scaled mul/div requir
leonardchan updated this revision to Diff 166756.
leonardchan added a reviewer: rjmccall.
leonardchan changed the repository for this revision from rC Clang to rL LLVM.
Repository:
rL LLVM
https://reviews.llvm.org/D52286
Files:
include/llvm/CodeGen/ISDOpcodes.h
include/llvm/IR/Intrinsics.t
leonardchan updated this revision to Diff 166746.
leonardchan added a comment.
Herald added a subscriber: cfe-commits.
- Removed passes since ssaturate can be expanded in the DAG
Repository:
rC Clang
https://reviews.llvm.org/D52286
Files:
include/llvm/CodeGen/ISDOpcodes.h
include/llvm/IR
