[PATCH] D52521: [Sema] DR727: Ensure we pick up enclosing template instantiation arguments for a class-scope explicit specialization.

erik.pilkington added a comment. No worries! It happens, I probably should have pinged this more aggressively. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52521/new/ https://reviews.llvm.org/D52521 ___ cfe-commits mailing list

[PATCH] D52521: [Sema] DR727: Ensure we pick up enclosing template instantiation arguments for a class-scope explicit specialization.

rsmith added a comment. In D52521#1479907 , @erik.pilkington wrote: > Looks like @rsmith fixed this in r359266. Sorry, I completely forgot about the existence of this when working on that patch! :( CHANGES SINCE LAST ACTION

[PATCH] D52521: [Sema] DR727: Ensure we pick up enclosing template instantiation arguments for a class-scope explicit specialization.

erik.pilkington abandoned this revision. erik.pilkington added a comment. Herald added a subscriber: jkorous. Looks like @rsmith fixed this in r359266. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52521/new/ https://reviews.llvm.org/D52521

[PATCH] D52521: [Sema] DR727: Ensure we pick up enclosing template instantiation arguments for a class-scope explicit specialization.

erik.pilkington added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:1771-1779 + void setIsSpecializedMember(bool V = true) { IsSpecializedMember = V; } + + /// If this class template specialization was declared at class scope (DR727). + /// For example,

[PATCH] D52521: [Sema] DR727: Ensure we pick up enclosing template instantiation arguments for a class-scope explicit specialization.

erik.pilkington updated this revision to Diff 168352. erik.pilkington added a comment. Address @rsmith's review comments. https://reviews.llvm.org/D52521 Files: clang/include/clang/AST/DeclTemplate.h clang/lib/Sema/SemaTemplateInstantiate.cpp clang/test/SemaCXX/member-spec-dr727.cpp

[PATCH] D52521: [Sema] DR727: Ensure we pick up enclosing template instantiation arguments for a class-scope explicit specialization.

rsmith added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:1771-1779 + void setIsSpecializedMember(bool V = true) { IsSpecializedMember = V; } + + /// If this class template specialization was declared at class scope (DR727). + /// For example, the

[PATCH] D52521: [Sema] DR727: Ensure we pick up enclosing template instantiation arguments for a class-scope explicit specialization.

erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:143 TSK_ExplicitSpecialization && !Function->getClassScopeSpecializationPattern())) break; It

[PATCH] D52521: [Sema] DR727: Ensure we pick up enclosing template instantiation arguments for a class-scope explicit specialization.

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, rjmccall. Herald added a subscriber: dexonsmith. Previously, we stopped early on a class-scope explicit specialization, leading us to lose enclosing levels of template arguments. I'm not entirely convinced that this