jkorous updated this revision to Diff 172951.
jkorous marked 4 inline comments as done.
jkorous added a comment.
Rewritten tests to shared implementation different cases.
https://reviews.llvm.org/D52554
Files:
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.c
jkorous marked 6 inline comments as done.
jkorous added inline comments.
Comment at: clangd/CodeCompleteTests.cpp:2043
+TEST(CompletionTestNoExplicitMembers, Struct) {
+ clangd::CodeCompleteOptions Opts;
sammccall wrote:
> sammccall wrote:
> > (Should this be
sammccall added a comment.
The assertions themselves all look good to me.
I don't think these should be new tests, they have substantial overlap with
TestAfterDotCompletion and should be incorporated there or those tests split up
to reduce the duplication.
(It's hard to avoid overlap/redundancy
jkorous created this revision.
jkorous added reviewers: sammccall, ilya-biryukov.
jkorous added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, kadircet, arphaman, dexonsmith, MaskRay,
ioeric.
Created in order to check we agree on what are the requirements and would later
wr
