This revision was automatically updated to reflect the committed changes.
Closed by commit rL343892: Emit CK_NoOp casts in C mode, not just C++.
(authored by jyknight, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343892: Emit CK_NoOp casts in C mode, not just C++.
(authored by jyknight, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52918?vs=168477=168541#toc
Repository:
rL LLVM
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for adding the test and the TODO!
https://reviews.llvm.org/D52918
___
cfe-commits mailing list
jyknight updated this revision to Diff 168477.
jyknight added a comment.
Added test.
https://reviews.llvm.org/D52918
Files:
clang/lib/AST/ExprConstant.cpp
clang/lib/Sema/SemaExpr.cpp
clang/test/Sema/c-casts.c
Index: clang/test/Sema/c-casts.c
jyknight added a comment.
In https://reviews.llvm.org/D52918#1256420, @aaron.ballman wrote:
> Patch is missing tests -- perhaps you could dump the AST and check the
> casting notation from the output?
It would appear that which casts get emitted in C mode is almost completely
untested. I
aaron.ballman added a comment.
Patch is missing tests -- perhaps you could dump the AST and check the casting
notation from the output?
https://reviews.llvm.org/D52918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jyknight created this revision.
jyknight added a reviewer: rsmith.
Previously, it had been using CK_BitCast even for casts that only
change const/restrict/volatile. Now it will use CK_Noop where
appropriate.
This is an alternate solution to r336746.
https://reviews.llvm.org/D52918
Files:
