This revision was automatically updated to reflect the committed changes.
Closed by commit rC344110: ExprConstant: Make __builtin_object_size use
EM_IgnoreSideEffects. (authored by jyknight, committed by ).
Herald added a subscriber: kristina.
Changed prior to commit:
george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
Thanks!
https://reviews.llvm.org/D52924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, looks like this has been largely redundant since r294800 removed the
only interesting thing that `EM_OffsetFold` did.
https://reviews.llvm.org/D52924
jyknight created this revision.
jyknight added a reviewer: rsmith.
And, since EM_OffsetFold is now unused, remove it.
While builtin_object_size intends to ignore the presence of
side-effects in its argument, the EM_OffsetFold mode was NOT
configured to ignore side-effects. Rather it was