rsmith added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:711
+
+ /// Evaluate as a constant expression, as per C++11-and-later constexpr
+ /// rules. Stop if we find that the expression is not a constant
jyknight wrote:
> rsmith wrote:
jyknight updated this revision to Diff 169641.
jyknight marked 11 inline comments as done.
jyknight added a comment.
Address most comments.
https://reviews.llvm.org/D52939
Files:
clang/include/clang/AST/Expr.h
clang/lib/AST/ExprConstant.cpp
Index: clang/lib/AST/ExprConstant.cpp
jyknight added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:12-32
// Constant expression evaluation produces four main results:
//
// * A success/failure flag indicating whether constant folding was
successful.
//This is the 'bool' return value used by
rsmith added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:12-32
// Constant expression evaluation produces four main results:
//
// * A success/failure flag indicating whether constant folding was
successful.
//This is the 'bool' return value used by
jyknight created this revision.
jyknight added a reviewer: rsmith.
The constant evaluation now returns false whenever indicating failure
would be appropriate for the requested mode, instead of returning
"true" for success, and depending on the caller examining the various
status variables after