[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

svenvh added a comment. In D53023#1499942 , @AlexeySotkin wrote: > LGTM! @joey, any idea when it will be landed? This work is being continued in https://reviews.llvm.org/D60763 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53023/new/

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

AlexeySotkin added a comment. LGTM! @joey, any idea when it will be landed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53023/new/ https://reviews.llvm.org/D53023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

Nicola added a comment. Since this review is just for a prototype, I'll leave some feedback after having played with it for a bit. It seems to be quite trivial to add new builtins and fix existing ones (conversion builtins sat/rounding modes). One builtin that might have a small issue is the

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

Nicola added a comment. This looks quite useful, thanks for taking time to do it! I can help verifying some of the tablegen'd builtins with internal tests too, if you decide to pursue this further. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53023/new/

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

joey updated this revision to Diff 172122. joey added a comment. I re-worked where the builtins are actually inserted, now it's in a similar place to the "normal" clang builtins. I addressed the issue of putting the return type also into the args type (could rename this to signature/proto

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

asavonic added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2247 if (R.empty() && HasTrailingLParen && II && !getLangOpts().CPlusPlus) { -NamedDecl *D = ImplicitlyDefineFunction(NameLoc, *II, S); -if (D) R.addDecl(D); +if (getLangOpts().OpenCL) { + auto

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

asavonic added a comment. > TODO > Measure the performance / size impact I looks like the total size of OpenCLBuiltinDecl table should be ~450KB (for ~15000 functions). I guess it can be reduced furthermore by: 1. Replacing return type with an index (you've mentioned this in TODO). 2. Replace

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

joey updated this revision to Diff 169182. joey added a comment. Re-uploading the patch. The previous version of the patch was missing the include and lib prefixes. https://reviews.llvm.org/D53023 Files: include/clang/Basic/CMakeLists.txt include/clang/Basic/OpenCLBuiltins.td

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

joey created this revision. joey added reviewers: asavonic, Anastasia. Herald added subscribers: cfe-commits, yaxunl, mgorny. This is the prototype for the approach that was mentioned by Anastasia in http://lists.llvm.org/pipermail/cfe-dev/2018-September/059529.html The tablegen file describes