This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344650: [clang-doc] Add unit tests for serialization
(authored by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53081?vs=169754&id=169907#toc
Repository:
rCTE Cla
jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.
LGTM, I'd file a bug about SmallString not taking const char* in its
constructor and I'd also put a TODO somewhere to fix that once that's resolved.
https://reviews.llvm.org/D5308
juliehockett updated this revision to Diff 169754.
juliehockett marked an inline comment as done.
https://reviews.llvm.org/D53081
Files:
clang-tools-extra/unittests/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/ClangDocTest.cpp
c
phosek added inline comments.
Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:320
+ ExtractInfosFromCodeWithArgs(
+ "export module M;\n"
+ "int moduleFunction(int x);\n"
Can you use raw strings here (and elsewhere in this file) as w
juliehockett updated this revision to Diff 169748.
juliehockett marked 2 inline comments as done.
https://reviews.llvm.org/D53081
Files:
clang-tools-extra/unittests/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/ClangDocTest.cpp
c
phosek added inline comments.
Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:27
+comments::FullComment *
+getComment(const NamedDecl *D) const {
+ if (RawComment *Comment = D->getASTContext().getRawCommentForDeclNoCache(D))
{
Nit: this func
juliehockett created this revision.
juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, mgorny.
This is part of a move to convert clang-doc's tests to a more maintainable unit
test fram
