[PATCH] D53085: [clang-doc] Add unit tests for Markdown

2018-10-16 Thread Julie Hockett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE344654: [clang-doc] Add unit tests for Markdown generation (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D53085?vs=169752=169911#toc Repository: rL

[PATCH] D53085: [clang-doc] Add unit tests for Markdown

2018-10-16 Thread Julie Hockett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL344654: [clang-doc] Add unit tests for Markdown generation (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D53085: [clang-doc] Add unit tests for Markdown

2018-10-15 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 169752. juliehockett marked an inline comment as done. https://reviews.llvm.org/D53085 Files: clang-tools-extra/unittests/clang-doc/CMakeLists.txt clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp Index:

[PATCH] D53085: [clang-doc] Add unit tests for Markdown

2018-10-14 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp:362 +} // namespace clang \ No newline at end of file Nit: this is relevant. https://reviews.llvm.org/D53085 ___

[PATCH] D53085: [clang-doc] Add unit tests for Markdown

2018-10-11 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 169221. juliehockett added a comment. Switching to raw strings. https://reviews.llvm.org/D53085 Files: clang-tools-extra/unittests/clang-doc/CMakeLists.txt clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp Index:

[PATCH] D53085: [clang-doc] Add unit tests for Markdown

2018-10-11 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp:44 + assert(!Err); + std::string Expected = "# namespace Namespace\n" + "\n" Can we use the C++11 raw string literals here and below to

[PATCH] D53085: [clang-doc] Add unit tests for Markdown

2018-10-10 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision. juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri. juliehockett added a project: clang-tools-extra. Herald added a subscriber: mgorny. This is part of a move to convert clang-doc's tests to a more maintainable unit test framework, with a