[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

This revision was automatically updated to reflect the committed changes. Closed by commit rOMP345867: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records (authored by gbercea, committed by ). Changed prior to commit:

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

ABataev accepted this revision. ABataev added a comment. LG Repository: rOMP OpenMP https://reviews.llvm.org/D53141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: libomptarget/deviceRTLs/nvptx/src/supporti.h:191 PRINT(LD_MEM, "malloc data of size %zu for %s: 0x%llx\n", size, msg, P64(ptr)); - ASSERT(LT_SAFETY, ptr, "failed to allocate %zu bytes for

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 172007. gtbercea added a comment. Reinstate assert. Repository: rOMP OpenMP https://reviews.llvm.org/D53141 Files: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu libomptarget/deviceRTLs/nvptx/src/interface.h

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

ABataev added inline comments. Comment at: libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu:159 omptarget_nvptx_threadPrivateContext->Level1TaskDescr(threadId); - ASSERT0(LT_FUSSY, newTaskDescr, "expected a task descr");

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 171993. gtbercea added a comment. Move while on else branch. Repository: rOMP OpenMP https://reviews.llvm.org/D53141 Files: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu libomptarget/deviceRTLs/nvptx/src/interface.h

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

ABataev added inline comments. Comment at: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu:442 +} + } while (!FrameP); Do you realy need the loop here? Seems to me it is better to have it in `else` branch of the `if (IsWarpMaster)` statement

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 171988. gtbercea added a comment. Address comments. Repository: rOMP OpenMP https://reviews.llvm.org/D53141 Files: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu libomptarget/deviceRTLs/nvptx/src/interface.h

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

ABataev added inline comments. Comment at: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu:389 unsigned WID = getWarpId(); + // void * volatile FramePointer = 0; void * = DataSharingState.FramePtr[WID]; This must be removed Comment

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 170238. gtbercea added a comment. Refactor. Repository: rOMP OpenMP https://reviews.llvm.org/D53141 Files: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu libomptarget/deviceRTLs/nvptx/src/interface.h

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 170236. gtbercea added a comment. Herald added subscribers: cfe-commits, jholewinski. Refactor. Repository: rC Clang https://reviews.llvm.org/D53141 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp Index: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp