[PATCH] D53192: [clangd] Do not query index for new name completions.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE345153: [clangd] Do not query index for new name completions. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D53192?vs=170900=170902#toc Repository: rCTE

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet added inline comments. Comment at: unittests/clangd/CodeCompleteTests.cpp:2180 + clangd::CodeCompleteOptions Opts; + Opts.AllScopes = true; + auto Results = completions(R"cpp( sammccall wrote: > Any need to actually enable this option, or just copied

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet updated this revision to Diff 170900. kadircet marked an inline comment as done. kadircet added a comment. - Change symbols name to get a match from index. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp

[PATCH] D53192: [clangd] Do not query index for new name completions.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: unittests/clangd/CodeCompleteTests.cpp:2180 + clangd::CodeCompleteOptions Opts; + Opts.AllScopes = true; + auto Results = completions(R"cpp(

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet updated this revision to Diff 170678. kadircet added a comment. - Use new enum types. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp clangd/index/SymbolCollector.cpp unittests/clangd/CodeCompleteTests.cpp Index:

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet updated this revision to Diff 170634. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp clangd/index/SymbolCollector.cpp

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet updated this revision to Diff 170626. kadircet added a comment. - Rebase and take in new changes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp clangd/index/SymbolCollector.cpp unittests/clangd/CodeCompleteTests.cpp Index:

[PATCH] D53192: [clangd] Do not query index for new name completions.

ilya-biryukov added a comment. A drive-by NIT ;-) Comment at: clangd/CodeComplete.cpp:643 case CodeCompletionContext::CCC_Recovery: + // TODO: Provide identifier based completions for the following two contexts: + case CodeCompletionContext::CCC_Name:

[PATCH] D53192: [clangd] Do not query index for new name completions.

sammccall added a comment. (This looks good, of course the Sema patch needs to land first!) Comment at: clangd/CodeComplete.cpp:643 case CodeCompletionContext::CCC_Recovery: + // TODO: Provide identifier based completions for the following two contexts: + case

[PATCH] D53192: [clangd] Do not query index for new name completions.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53192 Files: clangd/CodeComplete.cpp