This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345985: [analyzer][NFC] Fix some incorrect uses of
-analyzer-config options (authored by Szelethus, committed by ).
NoQ accepted this revision.
NoQ added a comment.
Yup, seems fine, please feel free to land! The `AggressiveReport` option looks
unused, we should probably remove it. Sry it took so long><
https://reviews.llvm.org/D53276
___
cfe-commits mailing
Szelethus added a comment.
@NoQ did you have time to ping Devin about this? (Sorry for the early ping, but
this patch is blocking a lot of my other patches.)
https://reviews.llvm.org/D53276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Szelethus updated this revision to Diff 171141.
Szelethus added a comment.
- Added description as @george.karpenkov mentioned.
Thanks! I guess it's up to @NoQ whether he and @dcoughlin are okay with making
some options checker options.
https://reviews.llvm.org/D53276
Files:
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Minor nitpicks, otherwise makes sense!
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:746
+ /// exploring a top level
Szelethus updated this revision to Diff 171130.
Szelethus added a comment.
`RetainCountChecker` now gets it's option when registering, like every other
checker.
`RetainCountChecker` stored a reference to `AnalyzerOptions`, evaluated an
option during construction, and one later down the line.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp:1401-1402
checker->IsAggressive =
- mgr.getAnalyzerOptions().getBooleanOption("AggressiveReport", false);
+ mgr.getAnalyzerOptions().getBooleanOption("AggressiveReport",
Szelethus updated this revision to Diff 170315.
Szelethus edited the summary of this revision.
Szelethus added a comment.
Herald added a subscriber: mgorny.
Added two more fixes, and added this to the summary:
- `lib/StaticAnalyzer/Checkers/AllocationDiagnostics.cpp` and
NoQ added a reviewer: dcoughlin.
NoQ added inline comments.
Herald added a subscriber: dkrupp.
Comment at: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp:1401-1402
checker->IsAggressive =
- mgr.getAnalyzerOptions().getBooleanOption("AggressiveReport", false);
+
