This revision was automatically updated to reflect the committed changes.
Szelethus marked an inline comment as done.
Closed by commit rC345989: [analyzer] New flag to print all -analyzer-config
options (authored by Szelethus, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D5
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345989: [analyzer] New flag to print all -analyzer-config
options (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5329
Szelethus marked 2 inline comments as done.
Szelethus added a comment.
Thanks! :)
Comment at: lib/FrontendTool/ExecuteCompilerInvocation.cpp:255
+ento::printAnalyzerConfigList(llvm::outs());
+return true;
+ }
george.karpenkov wrote:
> Hm, should we ret
Szelethus updated this revision to Diff 171611.
Szelethus added a comment.
Hardcoded the first entry as suggested by @george.karpenkov.
https://reviews.llvm.org/D53296
Files:
include/clang/Driver/CC1Options.td
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyze
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Good to go, with minor nits inline.
Comment at: lib/FrontendTool/ExecuteCompilerInvocation.cpp:255
+ento::printAnalyzerConfigList(llvm::outs());
+
Szelethus updated this revision to Diff 170438.
https://reviews.llvm.org/D53296
Files:
include/clang/Driver/CC1Options.td
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyzer/Frontend/FrontendActions.h
lib/Frontend/CompilerInvocation.cpp
lib/FrontendTool/Exec
Szelethus updated this revision to Diff 170432.
Szelethus edited the summary of this revision.
Szelethus added a comment.
Fixes according to inline comments, type and default value are generated now.
https://reviews.llvm.org/D53296
Files:
include/clang/Driver/CC1Options.td
include/clang/Sta
xazax.hun added a comment.
Overall looks good, minor comments inline.
Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp:166
+ "\n\n";
+ out << " clang [CLANG_OPTIONS] -analyzer-config OPTION1=VALUE, "
+ "-analyzer-config OPTION2=VALUE, ...\n
NoQ accepted this revision.
NoQ added a comment.
I'll use this.
And i think it's unfair to give users -analyzer-config and not give them a list
of options. Users should be able to discover either both or none of the two. If
a user goes far enough to start digging into non-driver options, such u
Szelethus updated this revision to Diff 169927.
Szelethus edited the summary of this revision.
Szelethus added a comment.
Added a test.
https://reviews.llvm.org/D53296
Files:
include/clang/Driver/CC1Options.td
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyze
Szelethus updated this revision to Diff 169925.
Szelethus edited the summary of this revision.
Szelethus added a comment.
Herald added a subscriber: nhaehnle.
Using `llvm::formatted_raw_ostream` to drastically simplify the previous
solution.
The actual output changed a little bit too, now I'm pr
Szelethus added a comment.
Cheers, thanks for the review!
In https://reviews.llvm.org/D53296#1265927, @george.karpenkov wrote:
> Also, that's a lot of code for printing options. I understand it's hard to do
> wrapping properly, but I'm not sure whether it makes sense for half of the
> `Checker
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
+1, I think this is a great addition!
BTW in theory it should be possible to go wild on compile-time programming, and
generate the entire description string at co
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC, rnkovacs.
Herald added subscribers: cfe-commits, donat.nagy, mikhail.ramalho, dmgreen,
a.sidorin, mgrang, szepet, whisperity.
Title says it all, here's how it look like locally:
OVERVIEW: Clang S
14 matches
Mail list logo
