This revision was automatically updated to reflect the committed changes.
Closed by commit rL346439: [Frontend/Modules] Show diagnostics on prebuilt
module configuration mismatch… (authored by dblaikie, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
whisperity updated this revision to Diff 173124.
whisperity added a comment.
Yes, down the line I realised the function is not needed. (It emits a
diagnostic because the diagnostic comes from comparing the AST file's config
blocks to the current (at the time of import) compilation.)
I have
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
While I'm not 100% sure about the actual fix - I'm confident enough that
@rsmith can provide any further clarification in post-commit.
the test case can probably be simplified before
whisperity updated this revision to Diff 172908.
whisperity added a comment.
Test was added.
Repository:
rC Clang
https://reviews.llvm.org/D53334
Files:
lib/Frontend/CompilerInstance.cpp
test/Modules/Inputs/module-mismatch.cppm
test/Modules/mismatch-diagnostics.cpp
Index:
whisperity planned changes to this revision.
whisperity added a comment.
In https://reviews.llvm.org/D53334#1288057, @dblaikie wrote:
> In https://reviews.llvm.org/D53334#1273877, @whisperity wrote:
>
> > @dblaikie I have created a test, but unfortunately `%clang_cpp` in LIT
> > invokes `clang
dblaikie added a comment.
In https://reviews.llvm.org/D53334#1273877, @whisperity wrote:
> @dblaikie I have created a test, but unfortunately `%clang_cpp` in LIT
> invokes `clang --driver-mode=cpp` which is not the same as if `clang++` is
> called. I'm trying to construct the following
whisperity updated this revision to Diff 170832.
whisperity retitled this revision from "[Frontend] Show diagnostics on prebuilt
module configuration mismatch too" to "[Frontend/Modules] Show diagnostics on
prebuilt module configuration mismatch too".
whisperity added a comment.
Herald added a
