[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

SquallATF added a comment. In D53476#1641049 , @hans wrote: > It looks like it was never committed. > > Peiyuan, what's the status here? This patch need rebase, I see recent have a commit rG7994e1d

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

hans added a comment. It looks like it was never committed. Peiyuan, what's the status here? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53476/new/ https://reviews.llvm.org/D53476 ___ cfe-commits mailing list cfe-

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

isuruf added a comment. Herald added a reviewer: jdoerfert. Herald added a project: clang. Was this patch merged in clang? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53476/new/ https://reviews.llvm.org/D53476 ___

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

hans accepted this revision. hans added a comment. Looks good to me. Repository: rC Clang https://reviews.llvm.org/D53476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

SquallATF updated this revision to Diff 170559. SquallATF added a comment. - add test Repository: rC Clang https://reviews.llvm.org/D53476 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/MSVC.cpp test/Driver/cl-options.c test/OpenMP/Inputs/resource_dir/x86_64-msvc-win32/

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

rnk requested changes to this revision. rnk added a comment. This revision now requires changes to proceed. Actually, can you please add -fopenmp to `test/Driver/cl-options.c` to verify that we accept `-fopenmp`? Repository: rC Clang https://reviews.llvm.org/D53476 ___

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D53476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

SquallATF created this revision. Herald added subscribers: cfe-commits, guansong. clang-cl driver has -fopenmp related code, but -fopenmp not alloewd press to clang-cl driver, this patch fixed it and allowed link to multiarch openmp library. Repository: rC Clang https://reviews.llvm.org/D53