This revision was automatically updated to reflect the committed changes.
Closed by commit rC345012: [AST] Do not align virtual bases in
`MicrosoftRecordLayoutBuilder` when (authored by aleksandr.urakov, committed by
).
Repository:
rC Clang
https://reviews.llvm.org/D53497
Files:
lib/AST/Re
aleksandr.urakov added a comment.
Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D53497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
> Also it seems that MicrosoftRecordLayoutBuilder with an external source and
> without one differ considerably, may be it is worth to split this and to
> create two different builders? I think that
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: rnk, rsmith, zturner, mstorsjo, majnemer.
aleksandr.urakov added a project: clang.
Herald added a subscriber: cfe-commits.
The patch removes alignment of virtual bases when an external layout is used.
We have two cases:
-
