[PATCH] D53501: [clang-query] Refactor Output settings to booleans

2018-10-24 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL345194: [clang-query] Refactor Output settings to booleans (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53501?vs=170

[PATCH] D53501: [clang-query] Refactor Output settings to booleans

2018-10-24 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE345194: [clang-query] Refactor Output settings to booleans (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D53501?vs=170431&id=170975#toc Repository: rL LLV

[PATCH] D53501: [clang-query] Refactor Output settings to booleans

2018-10-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from minor commenting nits. Comment at: clang-query/Query.h:17 #include "llvm/ADT/Optional.h" + #include Spurious newline, or did

[PATCH] D53501: [clang-query] Refactor Output settings to booleans

2018-10-22 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 170431. steveire added a comment. Update tests Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53501 Files: clang-query/Query.cpp clang-query/Query.h clang-query/QueryParser.cpp clang-query/QuerySession.h unittests/clang-query/Que

[PATCH] D53501: [clang-query] Refactor Output settings to booleans

2018-10-22 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. This will make it possible to add non-exclusive mode output. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53501 Files: clang-query/Query.cpp clang-query/Query