[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

tejohnson abandoned this revision. tejohnson added a comment. Abandoned in favor of new approach in https://reviews.llvm.org/D53890/https://reviews.llvm.org/D53891. Repository: rC Clang https://reviews.llvm.org/D53524 ___ cfe-commits mailing

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

pcc added inline comments. Comment at: docs/LTOVisibility.rst:9 unit's *LTO unit* is the subset of the linkage unit that is linked together -using link-time optimization; in the case where LTO is not being used, the -linkage unit's LTO unit is empty. Each linkage unit has only

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

tejohnson updated this revision to Diff 172181. tejohnson added a comment. Address comments: Promote -flto-unit to clang driver option (and test it) Adjust LTOVisibility.rst to reflect change of default and new option. Repository: rC Clang https://reviews.llvm.org/D53524 Files:

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

tejohnson added a comment. In https://reviews.llvm.org/D53524#1279288, @tejohnson wrote: > In https://reviews.llvm.org/D53524#1276038, @pcc wrote: > > > In https://reviews.llvm.org/D53524#1274505, @tejohnson wrote: > > > > > In https://reviews.llvm.org/D53524#1271387, @tejohnson wrote: > > > > >

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

pcc added a comment. In https://reviews.llvm.org/D53524#1279288, @tejohnson wrote: > In https://reviews.llvm.org/D53524#1276038, @pcc wrote: > > > In https://reviews.llvm.org/D53524#1274505, @tejohnson wrote: > > > > > In https://reviews.llvm.org/D53524#1271387, @tejohnson wrote: > > > > > > >

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

tejohnson added a comment. In https://reviews.llvm.org/D53524#1276038, @pcc wrote: > In https://reviews.llvm.org/D53524#1274505, @tejohnson wrote: > > > In https://reviews.llvm.org/D53524#1271387, @tejohnson wrote: > > > > > In https://reviews.llvm.org/D53524#1271357, @pcc wrote: > > > > > > >

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

pcc added a comment. In https://reviews.llvm.org/D53524#1274505, @tejohnson wrote: > In https://reviews.llvm.org/D53524#1271387, @tejohnson wrote: > > > In https://reviews.llvm.org/D53524#1271357, @pcc wrote: > > > > > The reason why LTO unit is always enabled is so that you can link > > >

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

tejohnson added a comment. In https://reviews.llvm.org/D53524#1271387, @tejohnson wrote: > In https://reviews.llvm.org/D53524#1271357, @pcc wrote: > > > The reason why LTO unit is always enabled is so that you can link > > translation units compiled with `-fsanitize=cfi` and/or > >

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

tejohnson added a comment. In https://reviews.llvm.org/D53524#1271357, @pcc wrote: > The reason why LTO unit is always enabled is so that you can link translation > units compiled with `-fsanitize=cfi` and/or `-fwhole-program-vtables` against > translation units compiled without CFI/WPD. With

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

pcc requested changes to this revision. pcc added a comment. This revision now requires changes to proceed. The reason why LTO unit is always enabled is so that you can link translation units compiled with `-fsanitize=cfi` and/or `-fwhole-program-vtables` against translation units compiled

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: dexonsmith, steven_wu, inglorion, mehdi_amini. Currently, -flto-unit is specified whenever LTO options are used (unless using the old LTO API). This causes vtable defs to be processed using regular LTO,