[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

aaronmondal added subscribers: MaskRay, phosek, compnerd, aaronmondal. aaronmondal added a comment. Herald added a subscriber: Enna1. Herald added a project: All. Hmm I tried to fiddle around with this but I'm out of my depth here. Pulling in @MaskRay @compnerd @phosek in the hopes that one of yo

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

starsid planned changes to this revision. starsid added a comment. Thanks. I missed that in the comment thread. Will send back for review once ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ https://reviews.llvm.org/D53608 ___

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

efriedma added a comment. From earlier review comment: > Missing changes to run the unittests (test/builtins/Unit/) for the new > functions. That's the most important part, so we have some confidence the code actually works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

starsid added a comment. I have tried my best to follow the conversation here and complete this patch. Please let me know if it is missing something, or if I need to assign new reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ h

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

starsid updated this revision to Diff 393340. starsid added a comment. fix commit author name and email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ https://reviews.llvm.org/D53608 Files: compiler-rt/lib/builtins/extendhftf2.c comp

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

starsid updated this revision to Diff 393335. starsid added a comment. rebase and resurrect Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ https://reviews.llvm.org/D53608 Files: compiler-rt/lib/builtins/extendhftf2.c compiler-rt/lib/

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

efriedma added a comment. Yes, it makes sense to provide these routines, but someone has to write the code to make it work. This patch is currently incomplete: > Took another look and seems like long double is hardcoded in many of the > builtins. So I think the current patch needs to rename a

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

troyj added a comment. Wound up here while trying to use compiler-rt for static linking with our downstream compiler. It seems that compiler-rt's current approach of only providing these routines on certain platforms is problematic because libgcc always provides them, and thus compiler-rt is n

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

manojgupta added a comment. In D53608#1423692 , @LuoYuanke wrote: > Hi > What's the status for __float128 support? Has it already been finished? Sorry, haven't looked at time for a while. Consider this change abandoned for now :( Repository: rCRT C

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

LuoYuanke added a comment. Herald added a subscriber: jdoerfert. Herald added projects: LLVM, Sanitizers. Hi What's the status for __float128 support? Has it already been finished? Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ https://revi

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

efriedma added a comment. Yes, that looks right. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D53608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

manojgupta added a comment. Took another look and seems like long double is hardcoded in many of the builtins. So I think the current patch needs to rename a lot of places using long double to __float128 type. Some examples where I think __float128 type (propagating the type in fp_lib.h) shoul

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

efriedma added a comment. `__extendxftf2` and `__trunctfxf2` are for conversions between x86 long double and `__float128`; you'll need to write implementations yourself. (That should be a separate patch.) > Thanks Eli. I also found out that GCC 4.9 does not seem to have these defined > even t

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

manojgupta added a comment. I am also getting these tests failures because of missing __trunctfxf2 and __extendxftf2. These are provided by libgcc but compiler-rt does not seem to have an implementation for them. Builtins-x86_64-linux :: compiler_rt_logbl_test.c Builtins-x86_64-linux :: div

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

manojgupta added inline comments. Comment at: lib/builtins/fp_lib.h:111 typedef __int128_t srep_t; -typedef long double fp_t; +typedef __float128 fp_t; #define REP_C (__uint128_t) efriedma wrote: > manojgupta wrote: > > Changed long double to __float128 on Eli

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

manojgupta updated this revision to Diff 170756. manojgupta added a comment. Added checked for defined(__FLOAT128__) || defined(__SIZEOF_FLOAT128__) Repository: rCRT Compiler Runtime https://reviews.llvm.org/D53608 Files: lib/builtins/CMakeLists.txt lib/builtins/fp_lib.h Index: lib/bui

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

efriedma added inline comments. Comment at: lib/builtins/fp_lib.h:111 typedef __int128_t srep_t; -typedef long double fp_t; +typedef __float128 fp_t; #define REP_C (__uint128_t) manojgupta wrote: > Changed long double to __float128 on Eli's advice in PR39376.

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

manojgupta added inline comments. Comment at: lib/builtins/fp_lib.h:107 +// __LDBL_MANT_DIG__ is set to 64 for x86_64. +#if __LDBL_MANT_DIG__ == 113 || defined(__x86_64__) #define CRT_LDBL_128BIT I really don't know the accurate set of checks that should be use

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

manojgupta created this revision. manojgupta added reviewers: efriedma, joerg. Herald added subscribers: Sanitizers, llvm-commits, delcypher, mgorny. float128 builtins are currently not built for x86_64. This causes linker to complain baout missing symbols when linking glibc 2.27 with float128 sup