This revision was automatically updated to reflect the committed changes.
Closed by commit rC345133: [autocompletion] Handle the space before pressing
tab (authored by yamaguchi, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53639?vs=170849=170856#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345133: [autocompletion] Handle the space before pressing
tab (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D53639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yamaguchi updated this revision to Diff 170849.
yamaguchi added a comment.
Updated HasSpace, added comments, fixed typo in the commit message
https://reviews.llvm.org/D53639
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
teemperor requested changes to this revision.
teemperor added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Driver/Driver.cpp:1514
+ // which should end up in a file completion.
+ bool HasSpace = false;
+ if (PassedFlags.endswith(","))
yamaguchi created this revision.
yamaguchi added reviewers: teemperor, ruiu.
Distinguish "--autocomplete=-someflag" and "--autocomplete=-someflag,"
because the latter indicates that the user put space before pushing tab
which should end up in a file completion.
https://reviews.llvm.org/D53639
