[PATCH] D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345903: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC. (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.

vsapsai added a comment. Thanks for the review, John. I'll update the comment with TODO and commit. https://reviews.llvm.org/D53674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D53674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.

vsapsai updated this revision to Diff 172051. vsapsai added a comment. Exclude commits tracked in a different review. https://reviews.llvm.org/D53674 Files: clang/lib/CodeGen/CGObjC.cpp clang/test/CodeGenObjCXX/arc-constexpr.mm Index: clang/test/CodeGenObjCXX/arc-constexpr.mm =

[PATCH] D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.

vsapsai updated this revision to Diff 172049. vsapsai added a comment. - Rename `EmitConstant` to `emitScalarConstant`. - Tweak comment to be explicitly about intended IR code, not about Obj-C++ code. https://reviews.llvm.org/D53674 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CGEx

[PATCH] D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2480 + SuppressResultRetain); } vsapsai wrote: > rjmccall wrote: > > This switch is just checking what you already computed as > > `SuppressResultRetain`. Plea

[PATCH] D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.

vsapsai marked 2 inline comments as done. vsapsai added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2527 + return TryEmitResult(CGF.EmitScalarExpr(e), + !shouldRetainObjCLifetime(type.getObjCLifetime())); + } vsapsai

[PATCH] D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.

vsapsai updated this revision to Diff 171168. vsapsai added a comment. - Address review comments. https://reviews.llvm.org/D53674 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CGExprScalar.cpp clang/lib/CodeGen/CGObjC.cpp clang/lib/CodeGen/CodeGenFunction.h clang/test/CodeGenO

[PATCH] D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.

vsapsai added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2480 + SuppressResultRetain); } rjmccall wrote: > This switch is just checking what you already computed as > `SuppressResultRetain`. Please just assert in the

[PATCH] D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2480 + SuppressResultRetain); } This switch is just checking what you already computed as `SuppressResultRetain`. Please just assert in the second case that th

[PATCH] D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.

vsapsai created this revision. vsapsai added reviewers: ahatanak, rjmccall. Herald added a subscriber: dexonsmith. Failed assertion is > Assertion failed: ((ND->isUsed(false) || !isa(ND) || > !E->getLocation().isValid()) && "Should not use decl without marking it > used!"), function EmitDeclRef