martong marked an inline comment as done.
martong added inline comments.
Comment at: cfe/trunk/unittests/AST/ASTImporterTest.cpp:3780
+ typedefNameDecl(hasName("U")));
+ ASSERT_TRUE(ToD->getUnderlyingType()->isIncompleteType());
+
shafik wrote:
> As far as
shafik added a comment.
Apologies for my late comments.
Comment at: cfe/trunk/unittests/AST/ASTImporterTest.cpp:3780
+ typedefNameDecl(hasName("U")));
+ ASSERT_TRUE(ToD->getUnderlyingType()->isIncompleteType());
+
As far as I can tell `S` is complete in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347648: [ASTImporter] Typedef import brings in the complete
type (authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53693/new/
https://reviews.llvm.org/D53693
___
martong added inline comments.
Herald added a reviewer: shafik.
Herald added a subscriber: gamesh411.
Comment at: lib/AST/ASTImporter.cpp:2310
+D->getUnderlyingType(), FoundTypedef->getUnderlyingType())) {
+ QualType FromUT = D->getUnderlyingType();
+
martong updated this revision to Diff 171478.
martong marked 2 inline comments as done.
martong added a comment.
- Move FromUT upper, add break
Repository:
rC Clang
https://reviews.llvm.org/D53693
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index:
a_sidorin added a comment.
Hi Gabor,
Thank you for the patch. I looks reasonable but I have some questions.
Comment at: lib/AST/ASTImporter.cpp:2310
+D->getUnderlyingType(), FoundTypedef->getUnderlyingType())) {
+ QualType FromUT =
martong created this revision.
martong added a reviewer: a_sidorin.
Herald added subscribers: cfe-commits, Szelethus, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
When we already have an incomplete underlying type of a typedef in the
"To" context, and the "From" context has the same
