[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

kristina commandeered this revision. kristina edited reviewers, added: return; removed: kristina. kristina added a comment. New revision in D54901 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53696/new/ https://reviews.llvm.org

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

kallisti5 added a comment. I don't have permission to update this request, so I created https://reviews.llvm.org/D54901 with the updates recommended. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53696/new/ https://reviews.llvm.org/D53696

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

kallisti5 added a comment. sorry, busy weekend. If you find the time feel free :-) - _GLIBCXX_USE_FLOAT128 can (and should) go - everything else is valid per the discussions here. Otherwise i'll pick up in the next few days and add the requested context as well. Repository: rC Clang CHANGE

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

kristina added a comment. Ping. Is the author still around? I'm happy to take over this revision if not, and add `__FLOAT128__` but unless someone says `_GLIBCXX_USE_FLOAT128` is actually defined by the toolchain, I'll remove that line, it looks like it really shouldn't be defined in the toolch

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

kristina requested changes to this revision. kristina added a comment. In https://reviews.llvm.org/D53696#1305990, @kallisti5 wrote: > Indeed. I agree the _GLIBCXX_USE_FLOAT128 is misplaced there. That comes > from config.h in libstdc++. That's working around an issue in Haiku's build > (lib

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

kallisti5 added a comment. Indeed. I agree the _GLIBCXX_USE_FLOAT128 is misplaced there. That comes from config.h in libstdc++. That's working around an issue in Haiku's build (libstdc++ is built by gcc, but then we try and use it with clang later) I can remove that. Is the __FLOAT128__ desi

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

kristina added a comment. Linux, Solaris and OpenBSD also define it where appropriate, it depends on the target. This is why it's much easier to review when full context (diff with `-U 9`) is provided, and means that it has a much lower change of `patch` doing something unexpected. Reposi

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

js requested changes to this revision. js added inline comments. This revision now requires changes to proceed. Comment at: lib/Basic/Targets/OSTargets.h:262 + Builder.defineMacro("__FLOAT128__"); + Builder.defineMacro("_GLIBCXX_USE_FLOAT128"); +} j

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

js added inline comments. Comment at: lib/Basic/Targets/OSTargets.h:262 + Builder.defineMacro("__FLOAT128__"); + Builder.defineMacro("_GLIBCXX_USE_FLOAT128"); +} This seems weird. Shouldn't by stdlibc++ and not by the compiler? Repository: rC Cl

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

kristina added a reviewer: kristina. kristina added a comment. Do you mind resubmitting those with context? Also I would suggest asking Tom Stellard as he's in charge of handling cherrypicking patches to go into releases once the major rolls over and I think we're pretty close (?) to 7.0.1. Re

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

kallisti5 added a comment. Thanks smeenai! Any chance of this one getting into 7.x.x? It's technically a bug fix... I think it's the last major hurdle to Haiku compiling (easily) with clang vs gcc. Repository: rC Clang https://reviews.llvm.org/D53696 _

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

return created this revision. return added reviewers: chandlerc, joerg. return added a project: clang. Herald added a subscriber: cfe-commits. This patch addresses a compilation error with clang when running in Haiku being unable to compile code using __float128 (throws compilation error such as