This revision was automatically updated to reflect the committed changes.
Closed by commit rL347564: [ASTImporter][Structural Eq] Check for
isBeingDefined (authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
martong added a comment.
I have reproduced the issue on MacOS, fixed it and updated the patch
accordingly.
Soon I will commit and will monitor if any build bots are being broken.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53697/new/
martong updated this revision to Diff 175241.
martong added a comment.
- Get data of CXXRecordDecl only if set
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53697/new/
https://reviews.llvm.org/D53697
Files:
lib/AST/ASTImporter.cpp
martong added a comment.
Herald added a subscriber: gamesh411.
@shafik,
I could run the libcxx tests on my Linux machine (Ubuntu 16.04) by installing
libcxx: `sudo apt-get install libc++-dev`.
From the logs of your build server seems like the crash happened with a
`_gmodules` test.
shafik added a comment.
@martong Hello, if I look at the specific test that was failing
`TestDataFormatterLibcxxVector.py` it only has the following decorator
`@add_test_categories(["libc++"])` so that should not prevent it from running
on Linux if you are also building libc++. If you do a
martong added a comment.
Herald added a reviewer: shafik.
Shafik,
Sorry for the inconvenience.
Seems like the libcxx tests of lldb are automatically skipped on Linux, so it
slipped through my test execution.
Also, I did not receive any email from this build server about the build
failure.
shafik added a comment.
I reverted this commit since it caused a regression in the lldb test suite,
specifically TestDataFormatterLibcxxVector.py.
See the logs here
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/12003/
Please monitor the lldb built bots when modifying ASTImporter.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345760: [ASTImporter][Structural Eq] Check for
isBeingDefined (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53697?vs=171723=171984#toc
Repository:
rC Clang
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Thank you for the explanation!
Repository:
rC Clang
https://reviews.llvm.org/D53697
___
cfe-commits mailing list
martong updated this revision to Diff 171723.
martong marked 2 inline comments as done.
martong added a comment.
- Remove unrelated test
Repository:
rC Clang
https://reviews.llvm.org/D53697
Files:
lib/AST/ASTStructuralEquivalence.cpp
unittests/AST/ASTImporterTest.cpp
Index:
martong marked 2 inline comments as done.
martong added a comment.
> I wonder if it is possible to get into situation where non-equivalent decls
> are marked equivalent with this patch? If yes, we can create a mapping
> between decls being imported and original decls as an alternative solution.
a_sidorin added a comment.
Hi Gabor,
I wonder if it is possible to get into situation where non-equivalent decls are
marked equivalent with this patch? If yes, we can create a mapping between
decls being imported and original decls as an alternative solution. However, I
cannot find any
12 matches
Mail list logo
