[PATCH] D53704: [ASTImporter] Import overrides before importing the rest of the chain

This revision was automatically updated to reflect the committed changes. Closed by commit rC345496: [ASTImporter] Import overrides before importing the rest of the chain (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D53704?vs=171097=171471#toc

[PATCH] D53704: [ASTImporter] Import overrides before importing the rest of the chain

martong added a comment. Hi Aleksei, Thanks for the review. Yes, we encountered the issue during the analysis of Xerces. Repository: rC Clang https://reviews.llvm.org/D53704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53704: [ASTImporter] Import overrides before importing the rest of the chain

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hello Gabor, The change looks harmless so I think it can be accepted even without tests. Did you encountered the issue while analyzing some real code? Repository: rC Clang

[PATCH] D53704: [ASTImporter] Import overrides before importing the rest of the chain

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. During method import we check for structural eq of two methods. In the structural eq check we check for their isVirtual()