[PATCH] D53719: [clang-tidy] UppercaseLiteralSuffixCheck: bugfix: don't cripple substNonTypeTemplateParmExpr

2018-10-25 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri created this revision. lebedev.ri added reviewers: JonasToth, aaron.ballman, alexfh, hokein, xazax.hun. lebedev.ri added a project: clang-tools-extra. Herald added subscribers: chrib, rnkovacs, kristof.beyls. The previous, clearly broken output: /tmp/test.cpp:4:17: warning: integer l

[PATCH] D53719: [clang-tidy] UppercaseLiteralSuffixCheck: bugfix: don't cripple substNonTypeTemplateParmExpr

2018-10-25 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. What do you mean by "general way to avoid"? Templates? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D53719: [clang-tidy] UppercaseLiteralSuffixCheck: bugfix: don't cripple substNonTypeTemplateParmExpr

2018-10-25 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In https://reviews.llvm.org/D53719#1276208, @JonasToth wrote: > What do you mean by "general way to avoid"? Templates? I'm basically asking "is the `unless(hasParent(substNonTypeTemplateParmExpr()))` fix correct? or is there something else i'm missing?" Repositor

[PATCH] D53719: [clang-tidy] UppercaseLiteralSuffixCheck: bugfix: don't cripple substNonTypeTemplateParmExpr

2018-10-25 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. > I'm basically asking "is the > `unless(hasParent(substNonTypeTemplateParmExpr()))` fix correct? or is there > something else i'm missing?" Ah ok, I am not aware of another way, but no

[PATCH] D53719: [clang-tidy] UppercaseLiteralSuffixCheck: bugfix: don't cripple substNonTypeTemplateParmExpr

2018-10-25 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri abandoned this revision. lebedev.ri added a comment. Reverted the check, reopened https://reviews.llvm.org/D52670. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53719 ___ cfe-commits mailing list cfe-commits@lists.llvm.o