[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356874: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

balazske marked an inline comment as done. balazske added inline comments. Comment at: lib/AST/ASTImporter.cpp:3418 - for (const auto *Attr : D->attrs()) -ToIndirectField->addAttr(Importer.Import(Attr)); a_sidorin wrote: > shafik wrote: > > Why is this

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Balasz, Sorry, I missed the review accidentally. Thank you for the patch! Comment at: lib/AST/ASTImporter.cpp:3418 - for (const auto *Attr : D->attrs()) -

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

shafik added inline comments. Comment at: lib/AST/ASTImporter.cpp:3418 - for (const auto *Attr : D->attrs()) -ToIndirectField->addAttr(Importer.Import(Attr)); Why is this section of code removed? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

martong added a reviewer: a_sidorin. martong added a subscriber: a_sidorin. martong added a comment. @shafik, @a_sidorin Ping. Could you please take a look? Guys, this and its child patch are very important patches, because without it the error handling of ASTImporter is not completed. This

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

balazske added a comment. This is the next part of the changes for error handling. D53818 was for `ASTImporter` functions only, this is for `ASTNodeImporter` (the `Import_New` functions are not used at many places directly because mostly the few import

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

balazske updated this revision to Diff 189824. balazske added a comment. Rebase (old patch applied without changes). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53757/new/ https://reviews.llvm.org/D53757 Files: lib/AST/ASTImporter.cpp Index:

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

martong added a comment. Herald added a subscriber: rnkovacs. > This patch is the next in the series of patches to finish the proper error > handling (i.e. using Error and Expected). Please see the "Stack" column > above. @balazske Or is it superseded by this one?

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

martong added a comment. Herald added a reviewer: martong. Herald added a project: clang. Ping. This patch is the next in the series of patches to finish the proper error handling (i.e. using Error and Expected). Please see the "Stack" column above. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

balazske updated this revision to Diff 175822. balazske added a comment. Removing previous wrong update. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53757/new/ https://reviews.llvm.org/D53757 Files: lib/AST/ASTImporter.cpp Index: lib/AST/ASTImporter.cpp

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

balazske updated this revision to Diff 175821. balazske added a comment. - Changed every use of ASTImporter::Import to Import_New Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53757/new/ https://reviews.llvm.org/D53757 Files: lib/AST/ASTImporter.cpp

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

balazske updated this revision to Diff 175675. balazske added a comment. Herald added a reviewer: shafik. Herald added a subscriber: gamesh411. Rebase to master. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53757/new/ https://reviews.llvm.org/D53757 Files:

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

balazske created this revision. Herald added subscribers: cfe-commits, Szelethus, martong, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D53757 Files: lib/AST/ASTImporter.cpp Index: lib/AST/ASTImporter.cpp