[PATCH] D53763: [libc++] [test] Fix logic error in tests; enable for MSVC previews

CaseyCarter closed this revision. CaseyCarter added a comment. I merged this as r351148. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53763/new/ https://reviews.llvm.org/D53763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D53763: [libc++] [test] Fix logic error in tests; enable for MSVC previews

CaseyCarter added a comment. In D53763#1356356 , @mclow.lists wrote: > I'm a bit concerned about the `TEST_HAS_NO_SPACESHIP_OPERATOR` and how it > tracks with `_LIBCPP_HAS_NO_SPACESHIP_OPERATOR`, but I'm not going to hold > this up for that. Same. I tr

[PATCH] D53763: [libc++] [test] Fix logic error in tests; enable for MSVC previews

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I'm a bit concerned about the `TEST_HAS_NO_SPACESHIP_OPERATOR` and how it tracks with `_LIBCPP_HAS_NO_SPACESHIP_OPERATOR`, but I'm not going to hold this up for that. CHANGES SINCE

[PATCH] D53763: [libc++] [test] Fix logic error in tests; enable for MSVC previews

CaseyCarter created this revision. CaseyCarter added reviewers: EricWF, mclow.lists. Fairly straightforward: these tests were written without an implementation of `<=>`, and they're incorrectly testing that `0 <=> foo` has the behavior that is required for `foo <=> 0`. https://reviews.llvm.org