rsmith added a comment.
In https://reviews.llvm.org/D53770#1297646, @greened wrote:
> Oops, I didn't realize this hadn't been formally accepted yet. Still
> learning the Phab process. Let me know if you want it reverted for a formal
> accept.
No, this is fine.
Repository:
rL LLVM
https
greened added a comment.
Oops, I didn't realize this hadn't been formally accepted yet. Still learning
the Phab process. Let me know if you want it reverted for a formal accept.
Repository:
rL LLVM
https://reviews.llvm.org/D53770
___
cfe-commi
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346802: [Driver] Support g++ headers in include/g++
(authored by greened, committed by ).
Herald added a subscriber: llvm-
rsmith added a comment.
Looks good with an accompanying test. (You can probably copy whatever was added
for the FreeScale line above.)
Repository:
rC Clang
https://reviews.llvm.org/D53770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
greened updated this revision to Diff 171801.
greened edited the summary of this revision.
greened added a comment.
Explain that Cray packages gcc such that headers are in include/g++.
Repository:
rC Clang
https://reviews.llvm.org/D53770
Files:
lib/Driver/ToolChains/Linux.cpp
Index: lib/
greened added inline comments.
Comment at: lib/Driver/ToolChains/Linux.cpp:927-928
LibDir.str() + "/../include/c++",
+ // Some gcc installations put headers under "g++" without a
+ // version suffix.
+ LibDir.str() + "/../include/g++",
rsmit
rsmith added a comment.
This needs a test.
Comment at: lib/Driver/ToolChains/Linux.cpp:927-928
LibDir.str() + "/../include/c++",
+ // Some gcc installations put headers under "g++" without a
+ // version suffix.
+ LibDir.str() + "/../include/g++",
greened created this revision.
greened added reviewers: danalbert, dlj, atanasyan, phosek.
Herald added a subscriber: cfe-commits.
Some gcc installations put C++ headers in PREFIX/include/g++ without indicating
a gcc version at all. Typically this is because the version is encoded
somewhere in
