[PATCH] D53837: [clang] Move two utility functions into SourceManager

2018-10-29 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri created this revision. lebedev.ri added reviewers: rsmith, aaron.ballman. lebedev.ri added a project: clang. Herald added subscribers: kbarton, nemanjai. So we can keep that not-so-great logic in one place. Repository: rC Clang https://reviews.llvm.org/D53837 Files: include/clan

[PATCH] D53837: [clang] Move two utility functions into SourceManager

2018-10-29 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, LG. I bet there's a bunch more places we could change to call these two. Repository: rC Clang https://reviews.llvm.org/D53837 ___ cfe-

[PATCH] D53837: [clang] Move two utility functions into SourceManager

2018-10-30 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL345594: [clang] Move two utility functions into SourceManager (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53837?vs

[PATCH] D53837: [clang] Move two utility functions into SourceManager

2018-10-30 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In https://reviews.llvm.org/D53837#1279891, @rsmith wrote: > Thanks, LG. I bet there's a bunch more places we could change to call these > two. Thank you for the review. Repository: rL LLVM https://reviews.llvm.org/D53837