juliehockett planned changes to this revision.
juliehockett marked 5 inline comments as done.
juliehockett added a comment.
In https://reviews.llvm.org/D53882#1282219, @aaron.ballman wrote:
> I am a bit confused by what this check is trying to accomplish. It seems like
> this is intended to catc
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:176
+
+ Warns when the `std` namespace is used, as its use is against Zircon's libc++
+ policy for the kernel.
JonasToth wrote:
> alexfh wrote:
> > JonasToth wrote:
> > >
aaron.ballman added a comment.
I am a bit confused by what this check is trying to accomplish. It seems like
this is intended to catch use of anything declared within the standard library,
but that includes library support things that are needed to write useful code.
For instance, it seems this
JonasToth added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:176
+
+ Warns when the `std` namespace is used, as its use is against Zircon's libc++
+ policy for the kernel.
alexfh wrote:
> JonasToth wrote:
> > s/its/it's/
> >
> > Could `
alexfh added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp:30
+ if (const NamedDecl *AN = Node.getAliasedNamespace()) {
+// If this aliases to an actual namespace, check if its std.
+if (const auto *N = dyn_cast(AN))
---
steveire added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp:52
+ Finder->addMatcher(
+ valueDecl(hasType(decl(hasDeclContext(namespaceDecl(isStdNamespace())
+ .bind("stdVar"),
Recommend extracting `na
JonasToth added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp:71
+void NoStdNamespaceCheck::check(const MatchFinder::MatchResult &Result) {
+ if (const auto *D = Result.Nodes.getNodeAs("stdVar"))
+diag(D->getBeginLoc(),
juliehockett updated this revision to Diff 171810.
juliehockett marked 5 inline comments as done.
https://reviews.llvm.org/D53882
Files:
clang-tools-extra/clang-tidy/zircon/CMakeLists.txt
clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp
clang-tools-extra/clang-tidy/zircon/NoStdNa
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp:71
+void NoStdNamespaceCheck::check(const MatchFinder::MatchResult &Result) {
+ if (const auto *D = Result.Nodes.getNodeAs("stdVar"))
+diag(D->getBeginLoc(),
-
JonasToth added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp:29
+AST_MATCHER(NamespaceAliasDecl, isAliasedToStd) {
+ if (const auto *AN = Node.getAliasedNamespace()) {
+// If this aliases to an actual namespace, check if its std. I
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Adds a checker to warn against using the std namespace, as Zircon's kernel
lib++ policy does not al
11 matches
Mail list logo