This revision was automatically updated to reflect the committed changes.
Closed by commit rC347352: [CodeComplete] Penalize inherited ObjC properties
for auto-completion (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53900?vs=171799=174838#toc
jkorous added reviewers: arphaman, benlangmuir.
jkorous added a comment.
This looks reasonable to me but asked people with more context to take a look.
Repository:
rC Clang
https://reviews.llvm.org/D53900
___
cfe-commits mailing list
sammccall added a comment.
As mentioned offline - sounds like someone from Apple might take a look.
If not, ping me again to land!
(Sorry for the delay)
Repository:
rC Clang
https://reviews.llvm.org/D53900
___
cfe-commits mailing list
dgoldman added a comment.
@sammccall to land this
Repository:
rC Clang
https://reviews.llvm.org/D53900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dgoldman added a comment.
Since I don't have commit access, sammccall will land this
Repository:
rC Clang
https://reviews.llvm.org/D53900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Looks sane to me, you might want someone more familiar with ObjC to verify
though.
Repository:
rC Clang
https://reviews.llvm.org/D53900
dgoldman created this revision.
Herald added subscribers: cfe-commits, arphaman.
Similar to auto-completion for ObjC methods, inherited properties
should be penalized / direct class and category properties should
be prioritized.
Note that currently, the penalty for using a result from a base
