[PATCH] D53912: [Headers] [MS] Add intrin0.h

2018-11-02 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment. Yes, the "real builtin" approach seems to be best. For a recent example, https://reviews.llvm.org/D49606 added `__shiftright128` as an inline function in intrin.h, but that didn't work with MSVC's STL when I moved our declaration of `__shiftright128` from intrin.h to i

[PATCH] D53912: [Headers] [MS] Add intrin0.h

2018-11-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a subscriber: STL_MSFT. rnk added a comment. In https://reviews.llvm.org/D53912#1284804, @azharudd wrote: > I agree. This currently resolves issues with building for ARM64 target using > Visual Studio 2017. The missing intrinsics it complains about are already > present in intrin.h. W

[PATCH] D53912: [Headers] [MS] Add intrin0.h

2018-11-01 Thread Azharuddin Mohammed via Phabricator via cfe-commits
azharudd added a comment. In https://reviews.llvm.org/D53912#1281584, @rnk wrote: > This sounds like it would defeat what I'm assuming is the intended purpose of > intrin0.h, which is to reduce compile time. intrin.h is kind of enormous, and > the compile time problems are well-documented. We s

[PATCH] D53912: [Headers] [MS] Add intrin0.h

2018-10-30 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. This sounds like it would defeat what I'm assuming is the intended purpose of intrin0.h, which is to reduce compile time. intrin.h is kind of enormous, and the compile time problems are well-documented. We should investigate what's up with intrin0.h and implement as many bu

[PATCH] D53912: [Headers] [MS] Add intrin0.h

2018-10-30 Thread Azharuddin Mohammed via Phabricator via cfe-commits
azharudd created this revision. azharudd added reviewers: rnk, mgrang. Herald added subscribers: jfb, mgorny. xatomic.h header in VS 2017 includes instead of like before. Adding an intrin0.h header which internally includes when compiling for the Windows platform. Repository: rC Clang http