void updated this revision to Diff 172194.
Repository:
rC Clang
https://reviews.llvm.org/D53921
Files:
lib/ARCMigrate/ObjCMT.cpp
lib/AST/ASTImporter.cpp
lib/AST/ExprConstant.cpp
lib/Analysis/CFG.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprAgg.cpp
lib/CodeGen/CGExprComplex.cpp
void updated this revision to Diff 172082.
Repository:
rC Clang
https://reviews.llvm.org/D53921
Files:
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/StmtDataCollectors.td
include/clang/Basic/StmtNodes.td
void marked 3 inline comments as done.
void added inline comments.
Herald added a reviewer: shafik.
Comment at: lib/Sema/SemaDecl.cpp:16086-16094
CheckConvertedConstantExpression(Val, EltTy, EnumVal,
CCEK_Enumerator);
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:5266-5268
+ bool VisitConstantExpr(const ConstantExpr *E) {
+return Visit(E->getSubExpr());
+ }
This shouldn't be necessary because you changed the CRTP base class
`ExprEvaluatorBase` to
void added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:16411
// this constant. Skip this enum since it may be ill-formed.
-if (!ECD) {
- return;
-}
+if (!ECD) return;
nickdesaulniers wrote:
> probably don't need to adjust this
void updated this revision to Diff 171976.
void retitled this revision from "Compound literals and enums require constant
inits" to "Compound literals, global array decls, and enums require constant
inits".
void edited the summary of this revision.
Repository:
rC Clang
