[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53928/new/ https://reviews.llvm.org/D53928 ___

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman updated this revision to Diff 186963. steleman added a comment. Addressed comments from Renato: - Diagnostic for unsupported argument to -fveclib= is now: error: unsupported option '' for target '' - Added check and diagnostic for SVML on non-Intel ISA's. Repository: rC Clang

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman added a comment. Hi Renato, Thank you very much for the comments. I will create a new changeset incorporating your comments, and then re-submit. I will also add a Diagnostic for SVML and X86/X86_64. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

rengolin added a comment. Herald added a subscriber: jdoerfert. Funny thing is, SVML is also only supported, AFAIK, for Intel. I agree that we should emit errors, but we should also emit a similar error on SVML. I know it's not entirely relevant to this patch, but we should keep the behaviour

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

rengolin added a comment. @hfinkel There are changes in this patch, as well as its LLVM counterpart D53927 . Please, re-review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53928/new/ https://reviews.llvm.org/D53928

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

rengolin requested changes to this revision. rengolin added a comment. This revision now requires changes to proceed. Since the previous version was approved already, I'm "requesting changes" so that we can look at it again, together with D53927 to make sure

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman updated this revision to Diff 185578. steleman added a comment. Herald added a project: clang. This is a small - but signifcant - update to the original changeset. What's new in this update: ${top_srcdir}/lib/Frontend/CompilerInvocation.cpp: When -fveclib=SLEEF was passed on

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Please, in the future, make sure you post full-context patches. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53928/new/

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman added a comment. Ping! Yes, I know, everyone was away for the holidays. :-) Could someone please take a look at this. We'd like to make sure everything is OK on this side before D53927 can proceed. Yes, it's a bit of a circular dependency in that

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman updated this revision to Diff 178884. steleman added a comment. Removed spurious patch for an unrelated change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53928/new/ https://reviews.llvm.org/D53928 Files: include/clang/Basic/Builtins.def

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

rengolin added reviewers: rsmith, chandlerc, rnk, ABataev. rengolin added a comment. Adding clang/omp developers for proper review. Please feel free to add more. FYI, there are four main ongoing discussions on the LLVM thread (D53927 ): 1. There is collusion

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman updated this revision to Diff 178477. steleman added a comment. Herald added a subscriber: arphaman. Updated version of this changeset/patch, as per Renato's latest comments from D53927 (https://reviews.llvm.org/D53927). New benchmark comparing SLEEF

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman updated this revision to Diff 172638. steleman added a comment. - changed the -fveclib= argument value to 'sleefgnuabi'. - added atan2 and pow. - spreadsheet with comparison between libm and sleef is here:

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman created this revision. steleman added a reviewer: joel_k_jones. Herald added subscribers: kristina, kristof.beyls, javed.absar. This changeset adds the required Builtins for enabling AArch64 vectorization of libm trigonometry functions via SLEEF: http://sleef.org/. - A new argument is