This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE346836: [clangd] Improve code completion for ObjC methods
(authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53934?vs=173737=173997#toc
Repository:
rCTE
dgoldman added a comment.
Since I don't have commit access, @sammccall will land this.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53934
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dgoldman updated this revision to Diff 173737.
dgoldman added a comment.
CodeCompleteTests fixes
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53934
Files:
clangd/CodeCompletionStrings.cpp
unittests/clangd/CodeCompleteTests.cpp
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this!
Comment at: unittests/clangd/CodeCompleteTests.cpp:2195
+TEST(CompletionTest, ObjectiveCMethodNoArguments) {
+ std::string Context = R"objc(
+
dgoldman created this revision.
dgoldman added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, jfb, arphaman, jkorous,
MaskRay, ioeric, ilya-biryukov.
Previously code completion did not work well for Objective-C methods
which contained multiple arguments as clangd did not
