ilya-biryukov updated this revision to Diff 172006.
ilya-biryukov added a comment.
- Instead of changing the interface, added a test we can rely on Context to
give us what we need
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53946
Files:
unittests/clangd/ClangdTests.cpp
I
sammccall added a comment.
Discussed offline a bit. We should be judicious with intrusive changes to
support out-of-tree clients, and this interface seems a bit messy.
There are alternatives with advantages:
1. less intrusive: clients can create a context before calling addDocument and
observe
ilya-biryukov added inline comments.
Comment at: clangd/TUScheduler.h:77
+class DiagnosticsResult {
+public:
To avoid boilerplate this could be changed to:
```
using DiagnosticsResult = Optional>;
```
Would still keep it a named typedef to allow documenting wh
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: kadircet, jfb, arphaman, jkorous, MaskRay, ioeric,
javed.absar.
NFC on the LSP level, only produces notifications in the C++ API.
Useful for the clients of the C++ API that provide an indicat
